Open
Conversation
|
View your CI Pipeline Execution ↗ for commit 655a94f
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/axe-plugin
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
# Conflicts: # project.json
BioPhoton
commented
Sep 1, 2025
# Conflicts: # packages/nx-plugin/src/executors/cli/schema.json # packages/nx-plugin/src/executors/cli/schema.ts
This was referenced Dec 1, 2025
BioPhoton
added a commit
that referenced
this pull request
Dec 2, 2025
Related to #1091 --------- Co-authored-by: John Doe <john.doe@example.com>
# Conflicts: # e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.ts
added 2 commits
December 4, 2025 21:11
# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.int.test.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts # packages/utils/src/index.ts # packages/utils/src/lib/logger.ts # packages/utils/src/lib/transform.unit.test.ts
added 5 commits
December 11, 2025 18:45
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c5137ea with previous commit 7b6e72c. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 18 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
656 other audits are unchanged. |
BioPhoton
commented
Dec 15, 2025
package.json
Outdated
| "private": true, | ||
| "dependencies": { | ||
| "@axe-core/playwright": "^4.11.0", | ||
| "@code-pushup/cli": "^0.96.1", |
Collaborator
Author
There was a problem hiding this comment.
We have to install it as it is a normal dependency, but in our nx.json we configure the execution of the local TS code.
BioPhoton
commented
Dec 15, 2025
package.json
Outdated
| "@axe-core/playwright": "^4.11.0", | ||
| "@code-pushup/cli": "^0.96.1", | ||
| "@code-pushup/models": "^0.96.1", | ||
| "@code-pushup/nx-plugin": "^0.96.1", |
Collaborator
Author
There was a problem hiding this comment.
We have to install it because ATM Nx plugins don't take import aliases in any way. This means our nx-plugin code is always 1 release behind the current PR
# Conflicts: # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precondition:
This PR includes:
Related:
closes #971
TODO Run local code
Changes where tested by:
npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1091nx.json{ "pluginsConfig": { "@code-pushup/nx-plugin": { "projectPrefix": "cli", "bin": "packages/cli/src/index.ts", "env": { "NODE_OPTIONS": "--import tsx", "TSX_TSCONFIG_PATH": "tsconfig.base.json" } } }, "plugins": [ { "plugin": "@code-pushup/nx-plugin", "options": { "targetName": "cp" } } ] }